textadventures.co.uk Forums

Quest Forum: [Solved] Quest 6 - Storing player location/inventory/etc

2021-01-04T03:11:29Z

Yep, that worked. Thanks!

Quest Forum: [Solved] Quest 6 - Storing player location/inventory/etc

2021-01-04T02:39:56Z

It seems the player isn't actually IN the room until they look at themself, and then they ARE in the room.

Ah . . . This gets me frequently (if it's what I think it is). Whatever command is moving the player needs to return world.SUCCESS (I think). Try that, and see if the changes take place when you expect.

Squiffy Forum: JS arrays in squiffy

2021-01-04T02:27:22Z

[[Start]]:
    var Arr1 = [];
    set ("Arr1", JSON.stringify(Arr1));
    var Arr2 = [];
    set ("Arr2", JSON.stringify(Arr2));
    Arr1[1]=5;
    Arr2[1]=42;
    set("Arr2_1",JSON.stringify(Arr2));
    
The attribute Arr1 has been set to the string: '{Arr1}'.

The attribute Arr2 has been set to the string: '{Arr2}'.

The attribute Arr2_1 has been set to the string: '{Arr2_1}'.

OK, now try [[Next]].

[[Next]]:
    var Arr1 = JSON.parse(get("Arr1"))
    set("test2", Arr1[1])
    var Arr2 = JSON.parse(get("Arr2"))
    set("test3", Arr2[1])
    var Arr2_1 = JSON.parse(get("Arr2_1"))
    set("test3", Arr2[1])
    set("test4", Arr2_1[1])

The middle element of that array is {test2}.

The middle element of that array is {test3}.

The middle element of that array is {test4}.

Quest Forum: Strange Attribute?

2021-01-04T02:20:32Z

Enter a command that returns the buggy text. Open the debugger, look at player.currentcommand. See what the command is.

For example, I have a "trees" object, the alias of which is a text processor directive {=game.SomeString}. game.SomeString contains an HTML image that displays instead of the regular text when you look at the "trees" object.

So when the box is checked by default, the command look at trees will be echoed, but with an image of trees instead of the alias "trees".

However, if you uncheck the box, look at trees will echolook at {=game.SomeString}, or sometimes look at <span><img src="blahblahblah"></span> (i.e., the contents of game.SomeString).

This is also what the debugger shows under player.currentcommand. So I am talking about the echoed command here, not the trees' "look" description.

Just FYI, this isn't a problem that I need to solve, more like a curiosity.

Quest Forum: Trouble Getting Special Link To Work

2021-01-04T02:18:40Z

Hi KV! I'm fine!

Oh. Thank you!

Quest Forum: [Solved] Quest 6 - Storing player location/inventory/etc

2021-01-04T02:12:24Z

That seems to have the same issue as just putting it in a regular variable.

EDIT: Nevermind, it... SEEMS to work? It didn't at first, but then it did. I dunno. It seems the player isn't actually IN the room until they look at themself, and then they ARE in the room. So I'll have to figure out what the 'look me' command does that triggers that.

Quest Forum: [Solved] Quest 6 - Storing player location/inventory/etc

2021-01-04T02:05:46Z

Hello.

Untested: I'd probably try game.player.locBak = game.player.loc before moving the player.

Quest Forum: Strange Attribute?

2021-01-04T01:58:05Z

Oh!
It's when you click on an object link. Then, the command sent to the server will include the object's alias. As far as Quest is concerned, the player typed in a bunch of text processor commands and it's just echoing back what you typed.

So I guess KV was right the first time :)

Squiffy Forum: JS arrays in squiffy

2021-01-04T01:40:40Z

doesn't seem to like leaving the array open

Not sure what you mean there.

does it need to be allocated

No; javascript is a high level language. An array is created by using [], whether or not you put values in them.

In this case, I get back true, not 5.

When you do set ("Arr1", JSON.stringify(Arr1));, you're setting the squiffy attribute to the string "[]" - the current values in that array. You can then add an element to the array, but the array is just a local variable.

The line in the second function, Arr1 = JSON.parse(get("Arr1")), restores that variable to the exact values it had when set ("Arr1", JSON.stringify(Arr1)) was called. In this example, an empty array.

So your second section, you look at Arr1[1] and get back undefined because the array is empty. I'm not sure what weirdness of Squiffy's text processor causes this to render as "true", but I think I've come across that quirk before.

If you want to add values to the array, you need to do that before the call to JSON.stringify.

That's one of the reasons I prefer the second option. 8 lines of script at the start of your game, and then you can trust Squiffy to save the values after each section.

Quest Forum: [Solved] Quest 6 - Storing player location/inventory/etc

2021-01-04T01:34:20Z

Hi,

I was just wondering how I could store the player's current location, or inventory, or other things, if they were going to be temporarily wiped/replaced with something else (for example, falling unconscious), before being replaced with their original location and inventory. I tried just putting it in a variable with foobar = game.player.loc, but upon returning the player using this variable, it seems they're not really there, as they can't interact with anything in the room.

Quest Forum: Trouble Getting Special Link To Work

2021-01-04T00:14:06Z

Hey! It's jmne!!!

Hello! I hope you're doing well!

If you want it to look like a gamebook, you definitely need hyperlinks.

https://textadventures.co.uk/forum/samples/topic/4772/how-to-make-a-text-adventure-look-like-a-gamebook

Quest Forum: Trouble Getting Special Link To Work

2021-01-03T23:02:12Z

Hi. So I'm working on a Steven Universe text adventure. I'm trying to get it to look like a gamebook. Do I need hyperlinks? I don't know what I'm doing.

So what I'm trying to do is move the player from one room to another. It's in the room description. This is what I have now:

You are at Ancient Ruins.
{exit:Aab}

This is my game. http://textadventures.co.uk/games/view/tu-ceu4k5eqd0m0ztu7zya/steven-universe-the-beginnings

Quest Forum: Strange Attribute?

2021-01-03T22:39:52Z

If unchecked, the directive's literal text will be printed out instead of the interpreted result of that directive. So I will leave it checked.

If you get bored, uncheck it.

Enter a command that returns the buggy text. Open the debugger, look at player.currentcommand. See what the command is. (If it's something interesting, come back with a screenshot!)

Squiffy Forum: JS arrays in squiffy

2021-01-03T20:54:21Z

I think that might do it. I'm going to have to play with it a bit. One thing I did see - I'm expecting it to be pretty large (800+). It (your first example) doesn't seem to like leaving the array open - does it need to be allocated?

[[Start]]:
    var Arr1 = [];
    set ("Arr1", JSON.stringify(Arr1));

    Arr1[1]=5;
    
The attribute Arr1 has been set to the string: '{Arr1}'.

OK, now try [[Next]].

[[Next]]:
    var Arr1 = JSON.parse(get("Arr1"))
    set("test2", Arr1[1])

The middle element of that array is {test2}.

In this case, I get back true, not 5.

Squiffy Forum: JS arrays in squiffy

2021-01-03T19:34:17Z

Actually, last night I poked around some more and found a conversation where someone talked about the same thing - JS variables and arrays do not cross into new sections - they are local to that section.

Technically, undeclared variables aren't even variables; they're properties.

If you just do Arr1 = [] without the var, it doesn't declare a local variable. It assumes Arr1 is shorthand for this.Arr1. But Squiffy does something a little odd (which I'd forgotten about), so even though this refers to something like squiffy.story.sections['Start'], setting an attribute on it doesn't work as expected.

The usual way of handling global variables in cases like this is to use an object you know to be global. For example, you can refer to window.Arr1, and know that it's the same variable everywhere. That's the easy way to use global JS variables in Squiffy.

But there's a downside. Squiffy attributes are stored in LocalStorage, so they're still there when the player closes the browser and opens it again. The same isn't true for JS variables, which only last as long as the window exists. So in this case, it still might be helpful to use a Squiffy attribute.

Which means arrays are out.

I don't see why it should be.

How about:

[[Start]]:
    var Arr1 = [0, 1, "foo"];
    set ("Arr1", JSON.stringify(Arr1));

The attribute Arr1 has been set to the string: '{Arr1}'.

OK, now try [[Next]].

[[Next]]:
    var Arr1 = JSON.parse(get("Arr1"))
    set("test2", Arr1[1])

The middle element of that array is {test2}.

JSON lets you turn a javascript data type into a string and back again. It's normally used when stuff like arrays and objects needs to be sent between a client and server; but it works just fine for storing arrays or other data in a Squiffy attribute. This method works fine whether it's arrays or plain objects you're dealing with. Or even arrays of objects.

An alternative I've used, to avoid having to explicitly use JSON everywhere, is to store them in a javascript variable, and put that into an attribute when saving. Something like (off the top of my head):

[[Start]]:
    // Redefining the save function, so that it will save our custom variable
    squiffy.story.save = function () {
        // This is what 'save' does by default:
        squiffy.set('_output', squiffy.ui.output.html());

        // Save our custom variable
        squiffy.set('myvariable', JSON.stringify(window.myvariable))

        // And abuse the 'transition' mechanism to make sure it's loaded again
        // by causing the javascript in a particular section to to be run as soon as this saved game is loaded
        squiffy.set('_transition', "squiffy.story.sections['load variables'].js")
    }
    window.myvariable = [];
    // Now we've guaranteed that window.myvariable exists, it will be accessible because it's in the context chain
    // so we don't need to look at it again

Now, take a look at the [[first section]].

[[load variables]]:
    window.myvariable = JSON.parse(get("myvariable"))

This section should never actually be visited, so it doesn't need text. It just makes sure that the variable is saved correctly.

[[first section]]:
    myvariable = ["apple", "banana"];

So what next?
Do you  like [more bananas], [cherries], or [peaches]?
Or would you like to see [[what the variable contains]]?

[more bananas]:
    myvariable.push("all the bananas")

Okay! Now what?

[cherries]:
    myvariable.push("cherry")

Okay! Now what?

[peaches]:
    myvariable.push("peaches")

Okay! Now what?

[[what the variable contains]]:
    set ('testvariable', myvariable.join(', '))

That variable contains: {testvariable}.

This means you have all the flexibility of a JS variable, which is accessible anywhere as long as you explicitly refer to it as window.myvariable the first time. And it persists into a saved game as well.

Squiffy Forum: JS arrays in squiffy

2021-01-03T15:47:35Z

Taking Var out of this code causes it to crash in Squiffy.

Actually, last night I poked around some more and found a conversation where someone talked about the same thing - JS variables and arrays do not cross into new sections - they are local to that section.

If you want to jump a variable to another section, you have to carry it across in a squiffy variable, using Set and Get commands. Which means arrays are out.

Which is okay. Last night in bed, I thought about it and figured a way to do it with just squiffy variables. I'm not sure how keen I am with this -an array would have been perfect. But you do what you can do with this application, I guess.

Quest Forum: [Solved] ClearScreen White Space Issue (was UNDO Issue)

2021-01-03T12:45:07Z

Apologies mrangel, in my rush to test your code yesterday I must have left in K.V.s code as well because tests this morning show white space returning. K.V.'s solution is reasonably specific anyway as it is only used when panes are removed and I have given it a thorough check (I think!)

Quest Forum: [Solved] Quest 6 - Remove default room name prefix

2021-01-03T08:56:57Z

Set "properName" to true.

QuestKit Forum: Visual Studio Code

2021-01-03T08:53:51Z

Sorry I've been busy with my father's funeral amongst other matters.

Actually I don't know any more than you. I have been using it to write (translate from BASIC) an Inform 6 game. I prefer the DARK theme for myself but there is also a menu choice - FILE/Preferences/Colour Theme to pick one that suits you.
With the I6 project, I just started a new file (I think) and began coding.
I'm still learning as I go, just as I did when working before I retired. (Life is just a continual schooling)

I'll try to get back to this fully in a few more weeks. Seems like I may have a bit of reading to do in order to catch up.

Squiffy Forum: JS arrays in squiffy

2021-01-03T06:34:39Z

Declaring a variable with var is optional, and makes it local to the current function.

Quest Forum: [Solved] Quest 6 - Remove default room name prefix

2021-01-03T04:55:19Z

Whoops, it's yet another thread.
I've been searching through the code for a while now, but I can't seem to find a way to disable the default room name prefix (i.e, the word "The" it insists on putting before everything).

Quest Forum: Increasing Attribute value is not working for me

2021-01-03T04:28:41Z

yep thats working now. Cheers.

Quest Forum: Strange Attribute?

2021-01-03T03:47:00Z

I was just curious to understand what that attribute did. I was surprised that unchecking that box could break so much of my game so easily!

If I leave it checked (game.echohyperlinks = true), my aliases which contain text processor directives work fine. If unchecked, the directive's literal text will be printed out instead of the interpreted result of that directive. So I will leave it checked.

Quest Forum: Quest 6 - Giving rooms custom attributes, and checking them later

2021-01-03T03:44:02Z

Thanks. I ended up actually writing my own function to teleport them:

async function teleport(dest) {
	game.player.loc = dest;
	msg(`<b>The ${w[game.player.loc].alias}</b>`);
	msg(w[game.player.loc].desc);
	return true;
}

Squiffy Forum: JS arrays in squiffy

2021-01-03T03:06:17Z

According to what I'm reading, variables (and arrays) in JS are all global in nature. However, I'm not having a lot of luck seeing arrays in functions. An example:

[[Start]]:

    var Arr1 = [];
    Arr1[0]=50;

    set("test1",Arr1[0]); //works
test1={test1}

[[Next]]

[[Next]]:
    set("test2",Arr1[0]); //fails
test2={test2}

Any ideas on how to use an array in other places (either JS functions or other squiffy sections)?

Quest Forum: Quest 6 - Giving rooms custom attributes, and checking them later

2021-01-03T02:43:09Z

To move the player, use world.setRoom.
https://github.com/ThePix/QuestJS/wiki/Attributes-for-items#worldsetroomchar-roomname-dir-forced

Quest Forum: Quest 6 - Giving rooms custom attributes, and checking them later

2021-01-03T02:15:07Z

[nevermind]

Quest Forum: Strange Attribute?

2021-01-02T19:52:13Z

Without hyperlinks, it's just printing the command the player typed; and that shouldn't contain text processor directives anyway.

Oh, I see. With hyperlinks, it's replacing key (which is the object's name as entered by the player) with the link.

Which means your "however" seems to be spot on.

...except if the player entered the first few letters, wouldn't the link be just those first few letter?

Also, I think Dcoder had issues with the text processor stuff in an object's name (or alias), and Quest maybe got updated to handle that in 5.8? (If not, there's some modified code to handle it in his game, I think.)

Quest Forum: Quest 6 - Giving rooms custom attributes, and checking them later

2021-01-02T19:41:16Z

game.player.loc will be a string (the name of the room).

That part would need to be w[game.player.loc].foo.

I saw something on the wiki about teleporting the player, but I can't find it now for the life of me. I can't remember the exact terminology used, but something on that wiki says what function to use when moving the player to a different room during play.

Quest Forum: [Solved] ClearScreen White Space Issue (was UNDO Issue)

2021-01-02T19:22:41Z

@mrangel, many thanks for the simplified code. I've tried it out on the cases that were failing and all seems perfect. I'll use a longer test tomorrow.

Quest Forum: Strange Attribute?

2021-01-02T19:18:56Z

KV I don't think that should be the problem. Without hyperlinks, it's just printing the command the player typed; and that shouldn't contain text processor directives anyway.

However, I do think that "{object:" + object.name + "}" should be "{object:" + object.name + ":" + key + "}" in that code; if the player types an object's alternate alias, it should echo what they typed.

Quest Forum: Increasing Attribute value is not working for me

2021-01-02T19:03:22Z

I can't see any problems with that.

I know timers don't work properly with precise times; but I'm not sure if using a floating point number for the interval will round it off, or just be ignored.

Does it work if you change

obfreefall1.value = obheight1.value  *  0.0048

obfreefall1.value = obheight1.value  *  3/625

?
That's the same number, but will round off the answer to be an int.

Quest Forum: [Solved] ClearScreen White Space Issue (was UNDO Issue)

2021-01-02T18:31:16Z

I have no idea why Quest keeps setting the document's min-height to the height of its contents. That should have no effect at all, except introducing pointless white space.

You might as well do something like $('head style').last().append('#divOutput {min-height: initial !important}') in your init script, and not have to keep fiddling with edge cases.

Quest Forum: Quest 6 - Giving rooms custom attributes, and checking them later

2021-01-02T17:59:07Z

Anyone know how I would go about giving a room a custom attribute, and then having it checked later?
For example:

createRoom("testroom", {
	desc:"a cool description",
	foo:"bar",
})

if (game.player.loc.foo != "bar") {
        do stuff
}

...While I'm here, I might as well ask if it's possible to teleport a player to another room, and store their inventory somewhere else when they do so.

Quest Forum: [Solved] ClearScreen White Space Issue (was UNDO Issue)

2021-01-02T16:11:58Z

Thanks K.V. I'd call it a joint effort but I still plan to buy another book from mrangel when I've finished the three I've downloaded already. I'm not currently working on any games so hopefully I won't be bothering the forum for a while.

QuestKit Forum: Publishing on Itch.io...

2021-01-02T15:48:44Z

It works perfectly now!

Quest Forum: [Solved] ClearScreen White Space Issue (was UNDO Issue)

2021-01-02T15:33:02Z

Hurray!

After reading through mrangel's posts in that old thread, that seemed like the fix.

So, mrangel technically solved this one.

Quest Forum: [Solved] ClearScreen White Space Issue (was UNDO Issue)

2021-01-02T15:06:17Z

Many thanks K.V. I've used your new code in place of the old, tying it specifically to tidying up after panes are removed, and everything now looks perfect. I've uploaded a new version of the game and it seems to be coping with every sequence I throw at it. I'll try playing through to just before the end and then undoing back to the beginning. It'll take a while!

QuestKit Forum: Publishing on Itch.io...

2021-01-02T14:52:05Z

Oops... Try it now.

Quest Forum: Strange Attribute?

2021-01-02T14:48:59Z

 <function name="HandleCommand" parameters="command, metadata">

This part:

        shownlink = false
        if (game.echocommand) {
          if (metadata <> null and game.enablehyperlinks and game.echohyperlinks) {
            foreach (key, metadata) {
              if (EndsWith(command, key)) {
                objectname = StringDictionaryItem(metadata, key)
                object = GetObject(objectname)
                if (object <> null) {
                  msg ("")
                  msg ("&gt; " + Left(command, LengthOf(command) - LengthOf(key)) + "{object:" + object.name + "}" )
                  shownlink = true
                }
              }
            }
          }
          if (not shownlink) {
            msg ("")
            OutputTextRaw ("&gt; " + SafeXML(command))
          }
        }

https://github.com/textadventures/quest/blob/2e521f35b4e780ae440b0b43a34e20794e7c0adc/WorldModel/WorldModel/Core/CoreParser.aslx#L44

This line: OutputTextRaw ("> " + SafeXML(command))

It looks like it doesn't use the text processor when that is unchecked.

You could try changing it to msg("> " + SafeXML(command)), but I did not test it.

QuestKit Forum: Publishing on Itch.io...

2021-01-02T14:24:43Z

You never set the game's status to published, so it's not available for anyone but you.

Quest Forum: [Solved] ClearScreen White Space Issue (was UNDO Issue)

2021-01-02T14:21:44Z

Man, I really wish I remembered doing all this. I have no clue where I came up with that code in UPDATE 2.

Anyway, it has something to do the min-height of the "divOutput" element.

Running this in the console after the undo makes the whitespace go away:

document.getElementById('divOutput').style.minHeight = null

So, try adding this line at the end of your undo script:

     JS.eval("document.getElementById('divOutput').style.minHeight = null")

Quest Forum: Increasing Attribute value is not working for me

2021-01-02T13:05:19Z

get input {
    if ((IsInt(result))) {
      obheight1.value = ToInt (result)
    }
    obfreefall1.value = obheight1.value  *  0.0048
    msg (" Recorded {obfreefall1.value} Seconds")
  }

Quest Forum: [Solved] Quest 6 - "can't access property "onCreation", hash is undefined"

2021-01-02T11:36:18Z

I would have suggested the same; it seemed odd to declare a local variable res and then discard it. But haven't seen the docs on this and wasn't sure how Quest 6 handles it.

Now I look at it, that seems an overly verbose way to create a template. To me, this seems both simpler and more intuitive:

const CYBERDECK = (procslots, memslots, driveslots, jackslots) => $.extend({},
	TAKEABLE_DICTIONARY, {
		procslots: procslots,
		memslots: memslots,
		driveslots: driveslots,
		jackslots: jackslots
	}
)

or even

const CYBERDECK = (procslots, memslots, driveslots, jackslots) => $.extend({
	procslots: procslots,
	memslots: memslots,
	driveslots: driveslots,
	jackslots: jackslots
}, TAKEABLE_DICTIONARY)

Quest Forum: Increasing Attribute value is not working for me

2021-01-02T09:11:53Z

The variable prints to screen as it should, such as - Time to Ground: 24
And I've been using IsInt and InInt as per above.

Timers and Timeout works fine when I enter a number as seconds, but not when I set it to expression and enter the variable.

Quest Forum: Strange Attribute?

2021-01-02T09:08:59Z

(Quest TA 5.8)

What does the "Display hyperlinks in commands" checkbox under the "Room Descriptions" tab of the game object do?

This checkbox corresponds to the Boolean attribute game.echohyperlinks (default setting is true).

I couldn't find an answer on the forums (or barely a mention). The reason I ask is that if I uncheck it (set to false), some of the object aliases in my game (that use text processor directives) fail to display properly.

Quest Forum: [Solved] ClearScreen White Space Issue (was UNDO Issue)

2021-01-02T08:29:32Z

Hi K.V., Happy New Year!
Sorry, my posting was lazy! I should have provided code. I've now done that in the game where I noticed the problem:
https://textadventures.co.uk/games/view/e4hrqb_vpeo4np1a0jel9g/l-too-another-mathemagical-adventure

To see the issue:

run the game online and type ABOUT to bring up a couple of pages of text
type CLEAR, which just uses ClearScreen to remove the text
type UNDO, which seems to insert the white space occupied by the text as a side effect of undoing CLEAR?

UPDATE
The problem seems to be in the code I use to restore the state of the game after UNDO, rather than UNDO itself, linked to code you gave me to deal with white space appearing when game panes are swapped out:
https://textadventures.co.uk/forum/quest/topic/w7mtakf7ykixomwl09kjfw/pain-with-panes-issue-3-expanding-whitespace

I'll experiment further!

UPDATE 2
You gave me the following code in 2018 to tidy up white space when taking out game panes:

JS.eval ("var reHeight = 0;  $('#divOutput').children().each(function(){reHeight += $(this).height();});  $('#divOutput').css('min-height',reHeight);")

Unfortunately that seems to fail after the use of ClearScreen. For example, in the posted game:

Type PANES twice to move panes in and out, showing all is fine
Type CLEAR
Type PANES twice again

On the second use, when removing the panes, white space appears. My easy workaround is to remove the use of ClearScreen but I'd love to know what was causing the problem?

Quest Forum: [Solved] Quest 6 - "can't access property "onCreation", hash is undefined"

2021-01-02T04:32:50Z

Ah, right. Thanks!

Quest Forum: [Solved] Quest 6 - "can't access property "onCreation", hash is undefined"

2021-01-02T03:27:38Z

Hello.

You're going to be mad . . .

You have to return res at the end of your function. This works:

const CYBERDECK = function(procslots, memslots, driveslots, jackslots) {
	const res = $.extend({}, TAKEABLE_DICTIONARY);
	res.procslots = procslots;
	res.memslots = memslots;
	res.driveslots = driveslots;
	res.jackslots = jackslots;
	return res;
}

createItem("cyberdeck", TAKEABLE(), CYBERDECK(1,1,1,1), {
	loc:"coffee_table",
	examine: "Your cyberdeck. It has slots for one processor, one stick of RAM, an internal drive, and, of course, a neural jack.",
})

BUT, since you extended the TAKEABLE dictionary in the template, you can leave the TAKEABLE() out of createItem, like so:

createItem("cyberdeck", CYBERDECK(1,1,1,1), {
	loc:"coffee_table",
	examine: "Your cyberdeck. It has slots for one processor, one stick of RAM, an internal drive, and, of course, a neural jack.",
})

REFERENCE

https://github.com/ThePix/QuestJS/wiki/Custom-Templates

Quest Forum: Increasing Attribute value is not working for me

2021-01-02T01:34:27Z

Are you sure you're waiting long enough for the timeout to trigger? It could take a few seconds longer than you expect.

I assume that you've checked the variable is an int.